Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Colon Rule] Fix case when comment is used in function call #3740

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

PaulTaykalo
Copy link
Collaborator

@PaulTaykalo PaulTaykalo commented Oct 11, 2021

This fixes #3719

@PaulTaykalo PaulTaykalo self-assigned this Oct 11, 2021
@PaulTaykalo PaulTaykalo added the hacktoberfest-accepted Pull requests accepted as valid Hacktoberfest contributions. label Oct 11, 2021
@SwiftLintBot
Copy link

SwiftLintBot commented Oct 11, 2021

12 Messages
📖 Linting Aerial with this PR took 0.73s vs 0.73s on master (0% slower)
📖 Linting Alamofire with this PR took 0.98s vs 0.97s on master (1% slower)
📖 Linting Firefox with this PR took 3.51s vs 3.49s on master (0% slower)
📖 Linting Kickstarter with this PR took 5.84s vs 5.81s on master (0% slower)
📖 Linting Moya with this PR took 0.48s vs 0.51s on master (5% faster)
📖 Linting Nimble with this PR took 0.41s vs 0.4s on master (2% slower)
📖 Linting Quick with this PR took 0.19s vs 0.19s on master (0% slower)
📖 Linting Realm with this PR took 2.11s vs 2.09s on master (0% slower)
📖 Linting SourceKitten with this PR took 0.33s vs 0.33s on master (0% slower)
📖 Linting Sourcery with this PR took 1.96s vs 1.96s on master (0% slower)
📖 Linting Swift with this PR took 3.11s vs 3.1s on master (0% slower)
📖 Linting WordPress with this PR took 6.44s vs 6.44s on master (0% slower)

Generated by 🚫 Danger

@PaulTaykalo PaulTaykalo force-pushed the fix/colon-rule-comment-in-argument branch from c306f5c to f33a2de Compare October 12, 2021 04:22
@PaulTaykalo PaulTaykalo merged commit a87aee1 into master Oct 14, 2021
@PaulTaykalo PaulTaykalo deleted the fix/colon-rule-comment-in-argument branch October 14, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Pull requests accepted as valid Hacktoberfest contributions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colon spacing rule false positive, autocorrect deletes inline comments
2 participants